docs(cupertino_http): Clarify that happens when a request is cancelled#1834
Merged
brianquinlan merged 2 commits intodart-lang:masterfrom Oct 15, 2025
Merged
docs(cupertino_http): Clarify that happens when a request is cancelled#1834brianquinlan merged 2 commits intodart-lang:masterfrom
brianquinlan merged 2 commits intodart-lang:masterfrom
Conversation
github-actions
bot
added
the
package:cupertino_http
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| cupertino_http | Breaking | 2.3.0 | 2.4.0-wip | 3.0.0 Got "2.4.0-wip" expected >= "3.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/cupertino_http/lib/src/cupertino_client.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| cupertino_http | ncb.NSURLCache | cupertino_api.dart::URLCache native_cupertino_bindings.dart::NSURLCache::getSharedURLCache native_cupertino_bindings.dart::NSURLCache::setSharedURLCache::value native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity native_cupertino_bindings.dart::NSURLCache::initWithMemoryCapacity$1 native_cupertino_bindings.dart::NSURLCache::init native_cupertino_bindings.dart::NSURLCache::new$ native_cupertino_bindings.dart::NSURLCache::allocWithZone native_cupertino_bindings.dart::NSURLCache::alloc native_cupertino_bindings.dart::NSURLCache::self$1 native_cupertino_bindings.dart::NSURLCache::retain native_cupertino_bindings.dart::NSURLCache::autorelease native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCache |
| cupertino_http | NSURLRequest | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest::request native_cupertino_bindings.dart::NSURLRequest::requestWithURL native_cupertino_bindings.dart::NSURLRequest::requestWithURL$1 native_cupertino_bindings.dart::NSURLRequest::initWithURL native_cupertino_bindings.dart::NSURLRequest::initWithURL$1 native_cupertino_bindings.dart::NSURLRequest::init native_cupertino_bindings.dart::NSURLRequest::new$ native_cupertino_bindings.dart::NSURLRequest::allocWithZone native_cupertino_bindings.dart::NSURLRequest::alloc native_cupertino_bindings.dart::NSURLRequest::self$1 native_cupertino_bindings.dart::NSURLRequest::retain native_cupertino_bindings.dart::NSURLRequest::autorelease native_cupertino_bindings.dart::NSURLRequest::initWithCoder native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::forRequest native_cupertino_bindings.dart::NSURLCache::removeCachedResponseForRequest::request |
| cupertino_http | NSURLRequestAttribution | native_cupertino_bindings.dart::NSURLRequest::attribution native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionDeveloper native_cupertino_bindings.dart::NSURLRequestAttribution::NSURLRequestAttributionUser native_cupertino_bindings.dart::NSURLRequestAttribution::values native_cupertino_bindings.dart::NSURLRequestAttribution::fromValue |
| cupertino_http | NSCachedURLResponse | native_cupertino_bindings.dart::NSURLCache::cachedResponseForRequest native_cupertino_bindings.dart::NSURLCache::storeCachedResponse::cachedResponse |
| cupertino_http | ncb.NSURLSessionDelegate | cupertino_api.dart::URLSession::delegate |
| cupertino_http | ncb.NSURLSessionConfiguration | cupertino_api.dart::URLSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getDefaultSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::getEphemeralSessionConfiguration native_cupertino_bindings.dart::NSURLSessionConfiguration::backgroundSessionConfigurationWithIdentifier native_cupertino_bindings.dart::NSURLSessionConfiguration::init native_cupertino_bindings.dart::NSURLSessionConfiguration::new$ native_cupertino_bindings.dart::NSURLSessionConfiguration::allocWithZone native_cupertino_bindings.dart::NSURLSessionConfiguration::alloc native_cupertino_bindings.dart::NSURLSessionConfiguration::self$1 native_cupertino_bindings.dart::NSURLSessionConfiguration::retain native_cupertino_bindings.dart::NSURLSessionConfiguration::autorelease |
| cupertino_http | SSLProtocol | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolUnknown native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol11 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol1 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol13 native_cupertino_bindings.dart::SSLProtocol::kDTLSProtocol12 native_cupertino_bindings.dart::SSLProtocol::kTLSProtocolMaxSupported native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol2 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3 native_cupertino_bindings.dart::SSLProtocol::kSSLProtocol3Only native_cupertino_bindings.dart::SSLProtocol::kTLSProtocol1Only native_cupertino_bindings.dart::SSLProtocol::kSSLProtocolAll native_cupertino_bindings.dart::SSLProtocol::values native_cupertino_bindings.dart::SSLProtocol::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocol |
| cupertino_http | tls_protocol_version_t | native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv11 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_TLSv13 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv10 native_cupertino_bindings.dart::tls_protocol_version_t::tls_protocol_version_DTLSv12 native_cupertino_bindings.dart::tls_protocol_version_t::values native_cupertino_bindings.dart::tls_protocol_version_t::fromValue native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMinimumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion native_cupertino_bindings.dart::NSURLSessionConfiguration::TLSMaximumSupportedProtocolVersion |
| cupertino_http | NSHTTPCookieStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::HTTPCookieStorage |
| cupertino_http | NSURLCredentialStorage | native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage native_cupertino_bindings.dart::NSURLSessionConfiguration::URLCredentialStorage |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/http/example/main.dart |
This check can be disabled by tagging the PR with skip-license-check.
liamappelbe
approved these changes
Oct 15, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 16, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/f4fbac4..6a8746e): 6a8746e 2025-10-13 Moritz Use newest verion of firehose in publish (dart-lang/ecosystem#378) http (https://github.com/dart-lang/http/compare/2c53fa3..2cb6c12): 2cb6c12 2025-10-15 Brian Quinlan chore(cronet_http): Prepare to release 1.6.0 (dart-lang/http#1833) a906598 2025-10-16 Denys Vitali fix(ok_http): trust manager init (dart-lang/http#1830) 54dfd63 2025-10-15 Brian Quinlan docs(cupertino_http): Clarify that happens when a request is cancelled (dart-lang/http#1834) 3e3c366 2025-10-15 Brian Quinlan chore(okhttp): Fix CI by setting minSdk=24 (dart-lang/http#1835) 6271faf 2025-10-13 Benjamin feat: export MediaType from http_parser (dart-lang/http#1803) 32dee0c 2025-10-13 Benjamin chore(cronet_http): bump compileSdkVersion to 34 (dart-lang/http#1832) tools (https://github.com/dart-lang/tools/compare/adf3fe7..f5920a2): f5920a2d 2025-10-16 Morgan :) Fix `PollingDirectoryWatcher` for delete during poll. (dart-lang/tools#2212) 289ba0d3 2025-10-15 Morgan :) Add DirectoryWatcher symlink tests. (dart-lang/tools#2206) 1275d4c3 2025-10-14 Kevin Moore Bump deps for graphs, html, process, pubspec_parse (dart-lang/tools#2210) 8b9a48ca 2025-10-14 Morgan :) Fix test handling of link timestamps. (dart-lang/tools#2208) 81588f32 2025-10-14 Abgar Simonean Update to oauth2 package README for Flutter Web info (dart-lang/tools#1961) webdev (https://github.com/dart-lang/webdev/compare/186bfe7..2517aa9): 2517aa94 2025-10-13 Srujan Gaddam [DWDS] Make pause a no-op on WebSocketProxyService (dart-lang/webdev#2697) Change-Id: Ifee5e199cf5799aa5962639e686192874f4d58b3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455480 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also snuck in adding the URI when throwing
RequestAbortedException.Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.